bump-formula-pr: use correct version in download path when --version is specified
=================================================================================
- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?
- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).
- [ ] Have you successfully run `brew tests` with your changes locally?
-----
When a `--version` is specified, use this specified version in the name of the downloaded file rather than the default that is parsed from the URL.
For instance,
```sh
brew bump-formula-pr --devel \
--url=http://www.zsh.org/pub/development/zsh-5.2-test-2.tar.gz \
--version=5.2-test-2 zsh
```
should download to `$HOMEBREW_CACHE/zsh-5.2-test-2.tar.gz` (correct behavior after this commit) rather than `$HOMEBREW_CACHE/zsh-2.tar.gz` (wrong behavior before this commit).
boneyard-formula-pr: make it more consistent with bump-formula-pr
=================================================================
- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?
- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).
- [ ] Have you successfully run `brew tests` with your changes locally?
-----
- Use ohai to print messages;
- Checkout last branch when done.
> Yeah, I wish it didn't work, but in terms of the PRs we might as well reap the rewards of the exploit and use the final url as soon as it resolves.
I think the commit could be swapped out when pulling to avoid another CI build. If `brew pull` is smart enough you might even be able do that automagically...
> I was lazy and used rebase merge, so here we go
Might directly pushing to master? Not really worth another PR...
By the way, putting vendored patches right in this repo would stop all this madness. (Yeah, I do remember the out-of-tree problem and debate on DSL.) macports/macports-ports is only 231M in size (repo + checked out tree), and their number of packages (10304) almost triples ours, so it shouldn't be scary.
pdksh: migrate from core
========================
Goes together with https://github.com/Homebrew/homebrew-core/pull/7601.
Created with `brew boneyard-formula-pr` because https://github.com/Homebrew/homebrew-core/pull/7538#issuecomment-264733049.
pdksh: migrate to boneyard
==========================
Created with `brew boneyard-formula-pr` because https://github.com/Homebrew/homebrew-core/pull/7538#issuecomment-264733049.
For the record, I'm having the same problem as bmcfee, and I've sent an email to [email protected] with details. Please don't hesitate to ask if you need additional info, thanks.