GHC 2016-12-18

21 comments.

, https://git.io/v1dqM in Homebrew/homebrew-core
```
grep -r dl.bintray.com
```

, https://git.io/v1dkV in Homebrew/homebrew-core
> you may have flipped

Not me.

> was that intentional…

Intentional.

>  Not sure what you meant by the 'Please remember to brew mirror imagemagick when merging.' part of this PR's description…

You don't need to understand that. Only maintainers can use `brew mirror`, and it uploads the tarball to Bintray so that the URL https://dl.bintray.com/homebrew/mirror/imagemagick-6.9.7-0.tar.xz works.

, https://git.io/v15QK in jarun/googler
Fix the disable-self-upgrade target in Makefile
===============================================

Regression in 6b913f6.

, https://git.io/v15Q6 in Homebrew/homebrew-core
imagemagick 6.9.7-0
===================

Created with `brew bump-formula-pr`.

---

Please remember to
```
brew mirror imagemagick
```
when merging.

, https://git.io/v15Qo in tdsmith/homebrew-pypi-poet
No problem!

, https://git.io/v154V in Homebrew/homebrew-core
Test of `yelp-tools` is failing, but that's because the XML schema http://projectmallard.org/1.0/mallard-1.0.rng can't be loaded (projectmallard.org is down at the moment); it shouldn't block the Python update.

, https://git.io/v15R1 in Homebrew/homebrew-core
googler 2.9
===========

Created with `brew bump-formula-pr`.

, https://git.io/v15RX in jarun/googler
Fine with me. For the record, I was using dest everywhere and always putting help on the second line so that all options have roughly the same format.

, https://git.io/v15lY in jarun/googler
Sure.

, https://git.io/v15C6 in jarun/googler
> Please push directly.

4827b5de0ead05a8cf5a309ddd9f0d6f91e19dff.

, https://git.io/v15CP in jarun/googler
It's been fun. In a sense.

, https://git.io/v15CM in jarun/googler
Remove deb package building and mention
=======================================

googler has been included in Debian Stretch and Ubuntu Yakkety. There's also a PPA listed. Most people should just use the official repos or the PPA.

Those who want to use an independent, latest version should choose another installation method, e.g., download the single script.

, https://git.io/v15Cy in jarun/googler
> Also, how about disabling the deb package generation now that we are on Ubuntu and have a well-maintained PPA too?

I'm writing the commit message right now :)

, https://git.io/v15lm in jarun/googler
We could use http://packages.ubuntu.com/search?keywords=googler&searchon=names since googler is already in an official release.

, https://git.io/v15lt in jarun/googler
> Also, instead of enter "exact" for an exact search., how about enter "x" for an exact search.? Keeps it short and sweet.

I was modeling the "exact" command on "unfilter", but no objection to "x".

, https://git.io/v15nQ in jarun/googler
> How about late today? ;)

No problem.

, https://git.io/v15n9 in tdsmith/homebrew-pypi-poet
Do not use prerelease versions of packages
==========================================

The `pypi.org/pypi/{package}/json` (or `pypi.python.org/pypi/{package}/json`) API returns all versions of a package, including prerelease versions; in particular, the default (`.urls` in the JSON payload) could be prerelease. Using `.urls` in the JSON payload by default (which currently means any package that is not a parsed dependency) results in the possibility of generated resources being a prerelease version, which is undesirable for Homebrew most of the time. For instance, prior to this commit, `poet -s wheel` or `poet -r wheel` would generate

```rb
  resource "wheel" do
    url "https://files.pythonhosted.org/packages/a7/37/947b4329c4a3c72093b6c8e9b4be8c7f10c32dbb78848d3a234ce01c059d/wheel-0.30.0a0.tar.gz"
    sha256 "98f3e09b4ad7f5649a7e3d00e0e005ec1824ddcd6ec16c5086c05b1d91ada6da"
  end
```

This commit switches to `pip.index.PackageFinder`, which automatically excludes prereleases unless `allow_all_prereleases` is set to True, and obviously better reflects what pip would actually install.

The known only "regression" is the inability of retrieving package homepage via this method, but since it's only ever used in `poet -f`, it shouldn't be a big problem for package authors, who should be aware of the package homepage anyway.

The other concern is that pip doesn't have a stable API officially, but the basic components being used here at least dates back to 6.0 from Dec 2014.

---

Alternatively, we can manually sort all versions returned by the `pypi.org/pypi/{package}/json` API and drop the prerelease versions.

, https://git.io/v15Ym in Homebrew/homebrew-core
Updated patch's commit hash. @tdsmith Might want to kill the CI builds #13367 and #13371.

, https://git.io/v15Yt in Homebrew/homebrew-core
> For some reason virtualenv picks up wheel 0.30.0a0

Apparently this has been fixed in virtulenv 15.1.0: https://github.com/pypa/virtualenv/blob/15.1.0/docs/changes.rst#1510-2016-11-15.

, https://git.io/v153Q in Homebrew/homebrew-core
Right. For some reason virtualenv picks up wheel 0.30.0a0, so poet generated this, and I didn't check...

, https://git.io/v15YI in Homebrew/formula-patches
Oops, accident.