GHC 2017-04-02

6 comments.

, https://git.io/vSlhn in jarun/nnn
This is just semantics... You can do `LDFLAGS = -s` (be aware that `-s` is an obsolete ld flag on Darwin and triggers a warning), but `strip` is fine too.

, https://git.io/vSlAB in jarun/nnn
Yep, and it belongs to LDFLAGS. See https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html. `-s` belongs to [options for linking](https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html#Link-Options).

, https://git.io/vSlAR in jarun/nnn
`-s` is an ld flag, not a cflag...

, https://git.io/vSlA0 in jarun/nnn
clang:

```
nnn.c:200:15: warning: comparison of array 'name' not equal to a null pointer is always true [-Wtautological-pointer-compare]
        last_slash = name != NULL ? strrchr(name, '/') : NULL;
                     ^~~~    ~~~~
```

Indeed, `name` is the char array on the stack, so it's never NULL.

Doing a `CC=clang make` could help you catch stuff like this.

, https://git.io/vSlbv in jarun/nnn
> But I think it would make sense if we remove the config.h removal stuff from the Makefile. 

Makes sense.

, https://git.io/vSlgg in asciinema/asciinema.org
Working now.