GHC 2017-04-07

11 comments.

, https://git.io/vSVMI in Homebrew/homebrew-core
It makes more sense to use a complete line as input.

, https://git.io/vSVP5 in Homebrew/homebrew-core
libev: add test
===============

#11898.

, https://git.io/vSV6l in Homebrew/homebrew-core
kite: add test
==============

#11898.

, https://git.io/vSV68 in Homebrew/homebrew-core
json-c: add test
================

#11898.

, https://git.io/vSV64 in Homebrew/homebrew-core
There are two possible exit codes. 1 if you use sandbox and it fails to read the device file. 0 if you --no-sandbox. Which is why I'm using pipe_output.

, https://git.io/vSV6B in Homebrew/homebrew-core
Wooh TIL.

, https://git.io/vSV6R in Homebrew/homebrew-core
Oh, and `pipe_output("bash -c 'blah blah'", "y\n")` is much less understandable as far as I am concerned. I know what `yes` commonly does. I don't know what the heck `y\n` is.

, https://git.io/vSV60 in Homebrew/homebrew-core
Because a typical use of pipe_output concerns a test command that can handle any input, or at least a class of input. You specify one (usually simple) input and check the output. Here, there's only one input that makes any sense at all.

, https://git.io/vSV6E in Homebrew/homebrew-core
I think `shell_output` makes much more sense here, because you should treat the entire thing as a test command, rather than, this part is the test command, that part is the input we feed into it (a y to answer a prompt...).

, https://git.io/vSV6u in Homebrew/homebrew-core
iftop: add test
===============

#11898.

, https://git.io/vSVoe in Homebrew/homebrew-core
autoenv: add test
=================

#11898.