GHC 2017-04-15

5 comments.

, https://git.io/vS5nI in Homebrew/brew
#2498 suppresses "Searching taps..." when a qualified formula is missing.

, https://git.io/vS5nL in Homebrew/brew
install: do not search taps when a qualified formula is missing
===============================================================

- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?
- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).
- [ ] Have you successfully run `brew tests` with your changes locally?

-----

You won't find the formula in another tap when it's already qualified.

Ref: https://github.com/Homebrew/brew/issues/2497#issuecomment-294317628.

, https://git.io/vS5nt in Homebrew/brew
> I find it baffling to call it "expected" brew would treat this case just as if I had typed brew install hybybzjfjnfnqqqqqqqqqq

It doesn't. "Searching for a previously deleted formula..." and "Searching for similarly named formulae..." are limited to qualified formulae in the tap specified. You can easily test this out yourself. That's why I said "Searching taps..." does nothing, because you'll never find the qualified formula in another tap. So missing formula handling code is definitely doing what it's expected to do.

> When brew sees that bar.rb is incorrectly formed (in whatever minor way that currently causes it to claim there is no such formula), it should raise a complaint and die.

And that is why I said it "probably could be handled better", but not the fault of missing formula handling code.

> it should raise a complaint and die...

Sure, raise a PR? This (as far as I understand) is an extremely narrow corner case, so someone needs to volunteer.

, https://git.io/vS5s7 in Homebrew/brew
@chdiza Your case probably could be handled better, but it is expected behavior. Well, I think "Searching taps..." does nothing here; but "Searching for a previously deleted formula..." and "Searching for similarly named formulae..." do very real things.

, https://git.io/vS5ed in Homebrew/brew
Syntax error results in `FormulaUnreadableError` (`formulary.rb:28`), which subclasses `FormulaUnavailableError`, which in turn triggers missing formula code.

Maybe `FormulaUnreadableError` should not subclass `FormulaUnavailableError`.