GHC 2017-06-28

2017-06-28 22:49:16, https://git.io/vQW90 in Homebrew/homebrew-core

caddy 0.10.4
============

Created with `brew bump-formula-pr`.

---

💿

2017-06-28 11:33:10, https://git.io/vQCYO in koraktor/braumeister.org

By the way, a quick fix would be replacing

```ruby
"https://github.com/#{name}/commit/#{rev.sha}##{@formula.path}"
```

with

```ruby
"https://github.com/#{@formula.repository.name}/commit/#{rev.sha}##{@formula.path}"
```

But I suspect controller logic may need some work to fix or prevent related problems (which I'm not aware of).

2017-06-28 10:00:08, https://git.io/vQchr in koraktor/braumeister.org

Repository name being nil on show.html leads to broken commit URLs
==================================================================

Take http://braumeister.org/formula/emacs for example. The commit URLs on that page look like <https://github.com//commit/f13c0414e35400fb1e1691f37407f5cb084ff884#Formula/emacs.rb>; the repo name `Homebrew/homebrew-core` is clearly missing from the URL.

I briefly looked at the codebase, and it seems that the problem lies in `FormulaeController#select_repository`. Unless the formula is a dupe, resulting in a URL like http://braumeister.org/repos/Homebrew/homebrew-apache/formula/ab, a regular formula URL like http://braumeister.org/formula/emacs has no `params[:repository_id]`, so `@repository` is `nil`, and consequently `FormulaeHelper#name` is also `nil`.