GHC 2017-10-17

8 comments.
, https://git.io/vd9MN in Homebrew/homebrew-core 
@ilovezfs I can't think of a single reason why you'd want a global youtube-dl config (clarification: by global I mean system-wide instead of user-specific). I'd say let's not carry a downstream patch that no user requested.
, https://git.io/vd9MA in Homebrew/homebrew-core 
Yeah, seems to work now.
, https://git.io/vdS6p in Homebrew/homebrew-core 
Right...
, https://git.io/vdS6h in Homebrew/homebrew-core 
The moc bottle now works for me too. Lovely.
, https://git.io/vdS6j in Homebrew/homebrew-core 
Sounds great...
, https://git.io/vdSie in Homebrew/homebrew-core 
Yeah.
, https://git.io/vdSiv in Homebrew/homebrew-core 
@ilovezfs A source build seems to eliminate the segfault, but still

```
could not handle external client request
```

and `mocp` still does not work.
, https://git.io/vdSRj in Homebrew/homebrew-core 
jack may be broken
==================

I was alerted to this issue by the OP of https://discourse.brew.sh/t/moc-and-mplayer-not-working-properly/1152.

```console
$ brew kegs berkeley-db jack
/usr/local/Cellar/berkeley-db/6.2.32 (5,632 files, 115.2MB) *
  Poured from bottle on 2017-10-17 at 07:13:36
/usr/local/Cellar/jack/0.125.0_1 (64 files, 1.1MB) *
  Poured from bottle on 2017-10-17 at 07:13:38
```

The issue can be reproduced with either `moc` or `mpv --with-jack`.

With `moc`:

```console
$ jackd -d coreaudio  # This is a blocking call, so have it in a separate terminal session.
jackd 0.125.0
Copyright 2001-2009 Paul Davis, Stephane Letz, Jack O'Quinn, Torben Hohn and others.
jackd comes with ABSOLUTELY NO WARRANTY
This is free software, and you are welcome to redistribute it
under certain conditions; see the file COPYING for details

JACK compiled with POSIX SHM support.
loading driver ..
Error calling AudioUnitSetProperty - kAudioUnitProperty_StreamFormat kAudioUnitScope_Output
could not handle external client request
(null)
Cannot open metadata DB at /tmp/jack-501/default/metadata.db: Unknown error: 1752629350
[1]    42868 segmentation fault  jackd -d coreaudio

$ mocp
Running the server...
Trying JACK...

FATAL_ERROR: Server exited!
```

The segfault happens immediately after launching `mocp`.

With `mpv --with-jack`:

```console
$ jackd -d coreaudio
jackd 0.125.0
Copyright 2001-2009 Paul Davis, Stephane Letz, Jack O'Quinn, Torben Hohn and others.
jackd comes with ABSOLUTELY NO WARRANTY
This is free software, and you are welcome to redistribute it
under certain conditions; see the file COPYING for details

JACK compiled with POSIX SHM support.
loading driver ..
Error calling AudioUnitSetProperty - kAudioUnitProperty_StreamFormat kAudioUnitScope_Output
could not handle external client request
(null)
Cannot open metadata DB at /tmp/jack-501/default/metadata.db: Unknown error: 167510098
[1]    42912 segmentation fault  jackd -d coreaudio

$ mpv --ao=jack some-video-or-audio-file
...
```

Note that `mpv` plays audio normally; the segfault only happens when `mpv` quits (you can quit immediately with `q`).

Since there are two separate repros, the issue seems to be in `jack`, or maybe `berkeley-db`. I don't have time (or actually the incentive) to investigate, so not sure if it's an upstream issue.

(Tests done on 10.12.6.)