GHC 2018-08-09

7 comments.

, https://git.io/fN9S4 in jarun/googler
Sure, take it your way. I'm not the one suggesting a weird "feature" here.

, https://git.io/fN9SB in jarun/googler
Actually, you know what, let me just write the script for you.

```sh
#!/bin/sh
open "$(python3 -c 'import sys, urllib.parse; print("https://www.google.com/search?q=%s" % urllib.parse.quote_plus(sys.argv[1]))' "$1")"
```

Done. No googler involved. Replace `open(1)` (macOS) with whatever launcher, e.g. `xdg-open`.

Note: It's not hard to implement percent-encoding natively in shell. I'm just being lazy here.

, https://git.io/fN9SR in jarun/googler
I don’t think spinning up the Python interpreter, import a million modules, run a lot of preparatory code just to do a percent encode is a good use of resources, or an improvement to googler. No, sorry it’s not, and we won’t encourage that by adding an option.

Btw, your implementation fetches and parses the results just to discard them and open the URL (which, as I said, is literally a percent encode away). Although that could have been changed.

, https://git.io/fN9S0 in jarun/googler
Well, the lucky option requires parsing Google results. What you’re requesting is literally a percent encode away...

, https://git.io/fN9SE in jarun/googler
To clarify, many people use macOS and have .DS_Store littered everywhere; many people use 
 Windows and have Thumbs.db littered everywhere (I believe; not really a Windows user). Etc. You don’t add those to the .gitignore of every single project.

, https://git.io/fN9Su in jarun/googler
That’s meant for your global gitignore.

, https://git.io/fN9Ma in jarun/googler
To search Google in a GUI browser, you just need to open a URL. How does this have anything to do with googler? We’re not building a launcher here.