GHC 2018-12-12

2018-12-12 17:22:55, https://git.io/fpdsV in Homebrew/homebrew-core

I don't think tar actually cares about whatever group the CI nodes use. To actually use `mutt_dotlock`, it has to be chgrp'ed to `mail` and setgid'ed, which is not really possible inside Homebrew, so I wouldn't worry about the group of the untarred executable.

2018-12-12 16:37:32, https://git.io/fpdtz in Homebrew/homebrew-core

mutt: always build mutt_dotlock
===============================

- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?
- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?
- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?
- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?

-----

Change `DOTLOCK_GROUP` to the current effective group (instead of `admin`, which is somewhat random anyway) so that `chgrp` on `mutt_dotlock` won't fail.

This makes sure the bottle isn't crippled: one can still set `$spoolfile` to `~/.mbox` if they want to.

Fixes #35032.

2018-12-12 16:02:34, https://git.io/fpdtg in Homebrew/homebrew-core

Oh, looking at the code, the reason is rather obvious; CI builds mutt `--with-homespool`.

2018-12-12 14:59:37, https://git.io/fp5bi in Homebrew/homebrew-core

`mutt_dotlock` is pretty integral to mutt's role as a MUA, missing it means the build is crippled. I'll look into it this evening.

(To be clear, this is by no means a new issue, I just didn't bother to report it until today. There's also a very old issue https://github.com/Homebrew/legacy-homebrew/issues/45400.)

2018-12-12 14:26:02, https://git.io/fp5bP in Homebrew/homebrew-core

Of course,

```console
$ brew config
HOMEBREW_VERSION: 1.8.5-12-gdbc43a7
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: dbc43a7a2bfb5013f2260ab040a6e37df1479365
Last commit: 30 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 019dbdf08b438b8d74c531cc425c5bcace94e79b
Core tap last commit: 5 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BINTRAY_KEY: set
HOMEBREW_BINTRAY_USER: zmwangx
HOMEBREW_CASK_OPTS: --verbose
HOMEBREW_DEVELOPER: 1
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_NO_ANALYTICS: 1
HOMEBREW_NO_AUTO_UPDATE: 1
HOMEBREW_VERBOSE: 1
HOMEBREW_VISUAL: /Users/zmwang/scripts/editor
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.3.7 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 10.0 build 1000
Git: 2.20.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 9.0.1
macOS: 10.14.2-x86_64
CLT: 10.1.0.0.1.1539992718
Xcode: 10.1
XQuartz: 2.7.11 => /opt/X11
```

```console
$ brew kegs mutt
/usr/local/Cellar/mutt/1.11.1 (121 files, 8.7MB) *
  Built from source on 2018-12-12 at 09:16:23
```

2018-12-12 14:24:36, https://git.io/fp5bX in Homebrew/homebrew-core

Bottled mutt doesn't include mutt_dotlock
=========================================

`mutt_dotlock` is typically setgid'ed so that mailboxes in `/var/mail` aren't readonly to mutt. However, bottled mutt seems to be missing the binary. Here's a comparison of the bottle and my local build on Mojave (no options):

```diff
$ diff =(brew ls mutt | sed 's:/usr/local/Cellar/::' | sort) =(tar tf ~/Library/Caches/Homebrew/downloads/4ecff6a2b696c40a5bd6987a151e69940e53e7ee475f9f3f8e6437f7f106905f--mutt-1.11.1.mojave.bottle.tar.gz | sed '/\/$/d' | sort)
--- /tmp/zshdTcp1z	2018-12-12 09:19:48.000000000 -0500
+++ /tmp/zshHQr8Vx	2018-12-12 09:19:49.000000000 -0500
@@ -7,7 +7,6 @@
 mutt/1.11.1/TODO
 mutt/1.11.1/bin/flea
 mutt/1.11.1/bin/mutt
-mutt/1.11.1/bin/mutt_dotlock
 mutt/1.11.1/bin/mutt_pgpring
 mutt/1.11.1/bin/muttbug
 mutt/1.11.1/bin/pgpewrap
@@ -100,6 +99,7 @@
 mutt/1.11.1/share/locale/it/LC_MESSAGES/mutt.mo
 mutt/1.11.1/share/locale/ja/LC_MESSAGES/mutt.mo
 mutt/1.11.1/share/locale/ko/LC_MESSAGES/mutt.mo
+mutt/1.11.1/share/locale/locale.alias
 mutt/1.11.1/share/locale/lt/LC_MESSAGES/mutt.mo
 mutt/1.11.1/share/locale/nl/LC_MESSAGES/mutt.mo
 mutt/1.11.1/share/locale/pl/LC_MESSAGES/mutt.mo
@@ -112,7 +112,6 @@
 mutt/1.11.1/share/locale/zh_CN/LC_MESSAGES/mutt.mo
 mutt/1.11.1/share/locale/zh_TW/LC_MESSAGES/mutt.mo
 mutt/1.11.1/share/man/man1/mutt.1
-mutt/1.11.1/share/man/man1/mutt_dotlock.1
 mutt/1.11.1/share/man/man1/mutt_pgpring.1
 mutt/1.11.1/share/man/man1/pgpewrap.1
 mutt/1.11.1/share/man/man1/smime_keys.1
```

Any idea?