Thanks for the suggestion. Since I'm too short on time at the moment to investigate this, could you please list which builds you have checked and which ones don't have avresample? (Kinda reluctant to deviate from the original without good reason.)
Sorry for the slow reply here... I believe I already thoroughly reviewed the changs last time and left very specific actionable comments. I'll fix up the commit according to my comments tomorrow, do a bit of testing, and close this.
Hi @amjith, sorry for the slow reply here and thanks for not forgetting about this!
Unfortunately, the new commits seem to have fixed my use case (where question marks are not quoted, as how prepared queries are written, *and* supplied parameters are quoted, which is okay) while breaking the existing and advertised one, namely smart (?) handling of quotes around parameters. Using the example on https://litecli.com/favorites/:
```sql
:memory:> CREATE TABLE users (name TEXT NOT NULL);
...
:memory:> \fs user_by_name select * from users where name = '$1'
...
:memory:> \f user_by_name "Skelly McDermott"
> select * from users where name = '"Skelly McDermott"'
```
Compare this to existing behavior where the last query would be `select * from users where name = 'Skelly McDermott'`.
Basically, the deeper problem is that quoting behavior expectations for the shell style (up to debate) and the prepared statement style (rather established, at least IMHO) are somewhat different.
I noticed that the newly added test cases only involve integers without quotes as parameters. Maybe adding ones with quoted strings written in various ways should make the issue clearer. Something like:
```py
# create table `test` with a TEXT field `name` first
run(executor, "\\fs sh_param_not_quoted select * from test where name=$1")
run(executor, "\\fs sh_param_quoted select * from test where name='$1'")
run(executor, "\\fs q_param select * from test where name=?")
run(executor, "\\f sh_param_not_quoted word") # never worked, probably shouldn't be supported
run(executor, "\\f sh_param_not_quoted 'two words'") # didn't work in the past, works now because quotes around the parameter aren't stripped
run(executor, "\\f sh_param_quoted word") # works
run(executor, "\\f sh_param_quoted 'two words'") # used to work, and documented on https://litecli.com/favorites/, but currently broken since again the quotes aren't stripped
run(executor, "\\f q_param word") # doesn't work, not sure if should be supported, but I can totally live with having to put quotes around "word"
run(executor, "\\f q_param 'two words'") # works, hurrah
```
(I'm typing this after a long day, so I didn't actually inspect the delta to understand what changed, and maybe I'm somehow confused and am testing the wrong thing... If that's the case please excuse me.)