GHC 2020-09-04

6 comments.

, https://git.io/JUseF in zmwangx/rust-ffmpeg-sys
Fixed in 34812ad22dc209909aef866737ae3f331106fb0a and passed in CI build against FFmpeg 3.3: https://github.com/zmwangx/rust-ffmpeg-sys/runs/1072974291?check_suite_focus=true Without the oddball feature flag.

Please let me know if this solves your problem. I'll cut a release if it works.

, https://git.io/JUseb in zmwangx/rust-ffmpeg-sys
Oh I forgot `ffmpeg-next-sys` is meant to support FFmpeg versions before 3.4 (`ffmpeg-next` only supports 3.4 or later which shouldn't have this problem). In that case this file should only be included when it exists.

, https://git.io/JUseN in zmwangx/rust-ffmpeg-sys
This requires adding a top level feature `lib_drm` to `Cargo.toml`, and honestly that doesn't make any sense at all, just look at the list of non-build features after that addition:

```
avcodec
avdevice
avfilter
avformat
avresample
postproc
swresample
swscale
lib_drm  // The heck? Each feature above is a library; this one is a largely irrelevant oddball dep few people's even heard of.
```

What exactly is the problem with unconditionally including `libavutil/hwcontext_drm.h`? Seems pretty harmless to me even if FFmpeg isn't built against libdrm.

, https://git.io/JUseA in zmwangx/rust-ffmpeg-sys
This just duplicates line 328.

, https://git.io/JU3dh in jarun/googler
No, this is intended. `<TAB>` indicates where you press tab to get autocomplete results, basically serving as a cursor here. The closing quote hasn’t been typed at that point. But thanks for the interest anyway.

, https://git.io/JU30c in jarun/googler
Sounds like a reasonable request. I’ll see if those can be easily extracted later. How they should be presented in our linear flow is already up to debate.