GHC 2020-10-03

10 comments.

, https://git.io/JU785 in zmwangx/rust-ffmpeg
Late reply but thanks for the contribution. @DuckerMan 

I think I'm satisfied with what we have now (well I should add a brief paragraph about MSVC).

, https://git.io/JUQpV in zmwangx/rust-ffmpeg-sys
Good point, thanks.

, https://git.io/JUQah in jarun/googler
Never mind then!

, https://git.io/JUQaj in jarun/googler
Late reply, but if you really need this you'll have to check stdin isn't a tty first (`sys.stdin.isatty()`). But I'd recommend command substitution, probably assigning to a variable first.

, https://git.io/JUQVe in jarun/googler
Might still want to take a look at that `googler-response-opa9i3yo`, if you still have it. Better fix it all now than have other issues pop up later.

, https://git.io/JUQVv in jarun/googler
Fix for failing tests
=====================

See individual commits.

, https://git.io/JUQVf in jarun/googler
> Attaching the response.

Actually I think you submitted your comment before the upload was complete, so that link's invalid, empty href.

, https://git.io/JUQVJ in jarun/googler
The "Second Edition" result doesn't show up in my results for "hello world", and when I search for "hello world manning":

```
$ googler hello world manning

 1.  Hello World! Second Edition - Manning
     https://www.manning.com/books/hello-world-second-edition
     Rating: 4.7, 16 reviews
     This updated and revised edition of Hello World! introduces the world of computer programming in a clear and engaging style. Written by Warren Sande
     and his ...

 2.  Hello World! Third Edition - Manning
     https://www.manning.com/books/hello-world-third-edition
     Rating: 4.7, 6 reviews
     Hello World! Computer Programming for Kids and Other Beginners, Third Edition introduces the world of computer programming in a clear and fun style.
     Using ...

...
```

complete with ratings. Can you send me your HTML? (Oh already did as I typed.)

, https://git.io/JUQVU in jarun/googler
Looking into it at the moment.

, https://git.io/JUQVT in jarun/googler
Fix parser
==========

Fixes #372, hopefully.

Old parser is kept just in case the new structure isn't served to every domain / every UA / every user.

Parser now capable of parsing multiple metadata fields too, e.g. "Released", "Genre", etc. for songs. Wikipedia search results often have these metadata fields, it seems. I have chosen ` | ` as the delimiter in our single-line output, which is of course debatable.

Example:

```console
$ googler linux

 1.  Linux.org
     https://www.linux.org/
     Sep 16, 2020
     Friendly Linux Forum.

 2.  Linux - Wikipedia
     https://en.wikipedia.org/wiki/Linux
     Source model: Open source | Userland: GNU | Initial release: September 17, 1991; 29 years a... | OS family: Unix-like
     Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17,
     1991, by ...

 3.  The Linux Foundation – Supporting Open Source Ecosystems
     https://www.linuxfoundation.org/
     Developer: Linus Torvalds
     The Linux Foundation supports the creation of sustainable open source projects and ecosystems in blockchain, deep learning, networking, and more.

...
```

```console
$ googler never gonna give you up

 1.  Never Gonna Give You Up - YouTube
     https://www.youtube.com/watch?v=dGeEuyG_DIc
     Mar 10, 2020, Uploaded by Carlos Marín, Topic
     Never Gonna Give You Up · Rick Astley Whenever You Need Somebody ℗ 1987 Sony Music Entertainment UK ...

 2.  Rick Astley - Never Gonna Give You Up (The Roxy 1987 ...
     https://www.youtube.com/watch?v=IO9XlQrEt2Y
     Jul 6, 2016, Uploaded by RickAstleyVEVO
     Never Gonna Give You Up” by Rick Astley, performed live at The Roxy, 1987 Listen to Rick Astley: https ...

 3.  The Story of the Best Meme EVER: "Never Gonna Give You Up"
     https://www.youtube.com/watch?v=QMW4AqbuSGg
     Jun 19, 2020, Uploaded by Alfo Media
     Never Gonna Give You Up / Rickrolling / Rickroll / Rick Astley / Live / Music Video / Review / Reaction / Video ...

 4.  Rick Astley - Never Gonna Give You Up [HQ] - YouTube
     https://www.youtube.com/watch?v=DLzxrzFCyOs
     Apr 11, 2015, Uploaded by AllKindsOfStuff
     Artist: Rick Astley Title: Never Gonna Give You Up Difference with original: nothing but the quality of audio and ...

 5.  Never Gonna Give You Up - Wikipedia
     https://en.wikipedia.org/wiki/Never_Gonna_Give_You_Up
     Released: 27 July 1987 | Producer(s): Stock Aitken Waterman | Genre: Dance-pop; blue-eyed soul; | Songwriter(s): Stock Aitken Waterman
     "Never Gonna Give You Up" is a song recorded by British singer and songwriter Rick Astley, released as his debut single on 27 July 1987. It was written
     and ...

...
```