GHC 2020-12-12

3 comments.

, https://git.io/JIiIH in zmwangx/rust-ffmpeg
Damn, focused on your diff and didn't see your example, sorry... Yeah, seems like a reasonable addition.

> There are a bunch of options that can be set but only before swr_init is called

Yeah, I did realize that shortly after suggesting the Settable trait. Another option is to expose standalone `swr_init` separately. That would be slightly more generalized as it allows reconfiguration, but I think I'll go with yours until someone presents an actual use case.

Will merge shortly.

, https://git.io/JIiIQ in zmwangx/rust-ffmpeg
Huh, seems I somehow completely ignored this question... Sorry. Closing due to age.

, https://git.io/JIiI7 in zmwangx/rust-ffmpeg
I was under the impression that `swr_alloc_set_opts` is already an alternative to `sw_alloc` plus a bunch of `av_opt_set_*`, but admittedly I haven't used swresample much. May I ask what are some examples of options that are not already covered?

Also, I wonder if it's better to implement the `util::options::Settable` trait than adding a method like this. (Edit: I realized that `swr_init` has to be called again after altering option values, a mechanism that's not currently exposed outside of the initial `get`).